Fix HttpBindingsMissing skipping REST protocol services#3122
Merged
Conversation
sugmanue
approved these changes
May 14, 2026
The `HttpBindingsMissingValidator` had a top-level short-circuit that returned early when no shape in the model carried `@http`. Services with a protocol like `restJson1` that requires `@http` on all operations would pass validation silently when no operations had the trait yet.
kstich
force-pushed
the
dev/kstich/fix-http-bindings-missing-validator
branch
from
3646a64 to
3ec4aa6
Compare
sugmanue
approved these changes
May 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
HttpBindingsMissingValidatorhad a top-level short-circuit that returned early when no shape in the model carried@http. Services with a protocol likerestJson1that requires@httpon all operations would pass validation silently when no operations had the trait yet.Fixes #3119
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.